ChangeSet 1.865.28.2, 2002/12/19 12:07:31-08:00, arnd@bergmann-dalldorf.de [PATCH] namespace pollution in STV0680 camera driver Variables should not be defined in a header file. This slightly improves the driver by making them static instead of global. diff -Nru a/drivers/usb/media/stv680.h b/drivers/usb/media/stv680.h --- a/drivers/usb/media/stv680.h Sun Dec 22 00:42:13 2002 +++ b/drivers/usb/media/stv680.h Sun Dec 22 00:42:13 2002 @@ -147,7 +147,7 @@ }; -unsigned char red[256] = { +static unsigned char red[256] = { 0, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 18, 25, 30, 35, 38, 42, 44, 47, 50, 53, 54, 57, 59, 61, 63, 65, 67, 69, @@ -172,7 +172,7 @@ 220, 220, 221, 221 }; -unsigned char green[256] = { +static unsigned char green[256] = { 0, 21, 21, 21, 21, 21, 21, 21, 21, 21, 21, 21, 21, 21, 21, 21, 21, 21, 21, 28, 34, 39, 43, 47, 50, 53, 56, 59, 61, 64, 66, 68, 71, 73, 75, 77, @@ -197,7 +197,7 @@ 245, 245, 246, 246 }; -unsigned char blue[256] = { +static unsigned char blue[256] = { 0, 23, 23, 23, 23, 23, 23, 23, 23, 23, 23, 23, 23, 23, 23, 23, 23, 23, 23, 30, 37, 42, 47, 51, 55, 58, 61, 64, 67, 70, 72, 74, 78, 80, 82, 84,